Merge pull request php-vcr#206 from alnorth/empty-string-post-fix

Make handling of empty strings in CURLOPT_POSTFIELDS consistent.

Author: renatomefi

src/VCR/Util/CurlHelper.php

@@ -157,7 +157,9 @@ public static function setCurlOptionOnRequest(Request $request, $option, $value,
  if (count($value) == 0) {
  $request->removeHeader('Content-Type');
  }
- } else {
+ } elseif (!empty($value)) {
+ // Empty values are ignored to be consistent with how requests are read out of
+ // storage using \VCR\Request::fromArray(array $request).
  $request->setBody($value);
  }
  $request->setMethod('POST');

tests/VCR/Util/CurlHelperTest.php

@@ -71,6 +71,18 @@ public function testSetCurlOptionOnRequestPostFieldsString()
  $this->assertEquals($payload, (string) $request->getBody());
  }
 
+ public function testSetCurlOptionOnRequestPostFieldsEmptyString()
+ {
+ $request = new Request('POST', 'example.com');
+ $payload = '';
+
+ CurlHelper::setCurlOptionOnRequest($request, CURLOPT_POSTFIELDS, $payload);
+
+ // This is consistent with how requests are read out of storage using
+ // \VCR\Request::fromArray(array $request).
+ $this->assertSame(null, $request->getBody());
+ }
+
  public function testSetCurlOptionOnRequestSetSingleHeader()
  {
  $request = new Request('GET', 'example.com');