Merge pull request php-vcr#220 from renatomefi/pr/192

CurlHook now returns integer HTTP status codes

Author: renatomefi

src/VCR/Util/CurlHelper.php

@@ -103,7 +103,7 @@ public static function getCurlOptionFromResponse(Response $response, $option = 0
  }
  break;
  case CURLINFO_HTTP_CODE:
- $info = $response->getStatusCode();
+ $info = (int)$response->getStatusCode();
  break;
  case CURLINFO_SIZE_DOWNLOAD:
  $info = $response->getHeader('Content-Length');

tests/VCR/LibraryHooks/CurlHookTest.php

@@ -176,10 +176,31 @@ public function testShouldReturnCurlInfoStatusCode()
  $infoHttpCode = curl_getinfo($curlHandle, CURLINFO_HTTP_CODE);
  curl_close($curlHandle);
 
- $this->assertEquals(200, $infoHttpCode, 'HTTP status not set.');
+ $this->assertSame(200, $infoHttpCode, 'HTTP status not set.');
+
  $this->curlHook->disable();
  }
 
+ /**
+ * @see https://github.com/php-vcr/php-vcr/issues/136
+ */
+ public function testShouldReturnCurlInfoStatusCodeAsInteger()
+ {
+ $stringStatusCode = "200";
+ $integerStatusCode = 200;
+ $this->curlHook->enable($this->getTestCallback($stringStatusCode));
+
+ $curlHandle = curl_init('http://example.com');
+ curl_setopt($curlHandle, CURLOPT_RETURNTRANSFER, true);
+ curl_exec($curlHandle);
+ $infoHttpCode = curl_getinfo($curlHandle, CURLINFO_HTTP_CODE);
+ curl_close($curlHandle);
+
+ $this->assertSame($integerStatusCode, $infoHttpCode, 'HTTP status not set.');
+
+ $this->curlHook->disable();
+ }
+
  public function testShouldReturnCurlInfoAll()
  {
  $this->curlHook->enable($this->getTestCallback());
@@ -340,11 +361,11 @@ function (Request $request) use ($testClass) {
  /**
  * @return \callable
  */
- protected function getTestCallback()
+ protected function getTestCallback($statusCode = 200)
  {
  $testClass = $this;
- return function () use ($testClass) {
- return new Response(200, array(), $testClass->expected);
+ return function () use ($statusCode, $testClass) {
+ return new Response($statusCode, array(), $testClass->expected);
  };
  }
 }