Skip to content

attach fetch response object on error #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dai-shi merged 1 commit into from
Apr 19, 2020
Merged

attach fetch response object on error #41

dai-shi merged 1 commit into from
Apr 19, 2020

Conversation

@dai-shi
Copy link
Owner

@dai-shi dai-shi commented Apr 17, 2020

closes #40
@dai-shi dai-shi mentioned this pull request Apr 17, 2020
Closed
@dai-shi dai-shi merged commit e344e66 into master Apr 19, 2020
@dai-shi dai-shi deleted the issue-40 branch April 19, 2020 00:23
Avantjurist
Avantjurist reviewed Apr 21, 2020
View reviewed changes
src/use-async-task-fetch.js
const createFetchError = (message, responseBody) => {
const err = new Error(message);
const createFetchError = (response, responseBody) => {
const err = new Error(`${response.statusCode} ${response.statusText}`);
Copy link

@Avantjurist Avantjurist Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status instead statusCode
Copy link
Owner Author

@dai-shi dai-shi Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/Response/status

Oops! Please note, my recommendation is to use err.response.status instead of err.message, which is rather for logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dai-shi @Avantjurist