Skip to content

Conversation

@sliptype
Copy link
Contributor

@sliptype sliptype commented May 2, 2019

Summary

I'm working on a pragma to support JSX when rendering React components in Cycle.

To support the MVI architecture and the special sel prop I need access to incorporate.

Changes

  • Export incorporate from ./incorporate in src/index.ts
@staltz
Copy link
Member

staltz commented May 2, 2019

This seems like an easy win, thanks for the PR!

Once you're satisfied with cycle-react-pragma (e.g. after it has Babel support), would you also be interested in sending a PR to put the pragma in this repo?

@staltz staltz merged commit 8ef4ab7 into cyclejs:master May 2, 2019
@staltz
Copy link
Member

staltz commented May 2, 2019

Released 2.1.0

@sliptype
Copy link
Contributor Author

sliptype commented May 2, 2019

Thanks for the quick response!

Yeah, I will definitely make a PR once it's polished. I think this will be really cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants