Skip to content

Fix x/2/y. It was yielding (xy)/2 rather than x/(2y). #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arnog merged 1 commit into from
Feb 25, 2024
Merged

Fix x/2/y. It was yielding (xy)/2 rather than x/(2y). #144

arnog merged 1 commit into from
Feb 25, 2024

Conversation

@dcbradley
Copy link

@dcbradley dcbradley commented Feb 25, 2024

This patch fixes a problem in symbolic evaluation of the division of a fraction by something else.

How to reproduce

const ce = new ComputeEngine(); var expr = ce.parse("(x/2)/y"); console.log(expr.json);

Actual behavior

[ 'Divide', [ 'Multiply', 'x', 'y' ], 2 ]

Expected behavior

[ 'Divide', 'x', [ 'Multiply', 2, 'y' ] ]

Environment

compute-engine 0.23.1

I have not tried previous versions.

Cheers!
@arnog
Copy link
Member

arnog commented Feb 25, 2024

Oops. Good catch and good fix. Thanks!
@arnog arnog merged commit a2b45a8 into cortex-js:main Feb 25, 2024
@dcbradley dcbradley deleted the div-div-fix branch February 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dcbradley @arnog