Skip to content

Conversation

@insightfuls
Copy link
Contributor

@insightfuls insightfuls commented Oct 16, 2025

What

The use.schema.id functionality for publishing broke between v2.11.1 and v2.12.0, because the signature of the sr.lookup_schema() function changed to add the fmt argument before the deleted argument (diff showing schema_registry_client.py showing the change at target line 828) so when called passing arguments positionally as part of looking up a provided schema ID, the True intended for deleted is passed as fmt, and a POST is made with a query string including &deleted=False&format=True where it should have had simply &deleted=True. This is causing our schema registry, at least, to throw back a 500 Server Error. I've fixed it by passing some arguments by name, including in some similar methods.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • I'm not familiar enough with the codebase to easily add a unit test for this. Clearly the breakage slipped through the test suite, though, so it would be preferable to add one.

Test & Review

I'll report back once I'm able to test the changes in a real environment. I have successfully tested this fixes the issue I was experiencing in a real environment.

Open questions / Follow-ups

  • Was the breaking signature change even intentional?

Review stakeholders

  • @fangnx committed the code which broke it, so may have a stake in the fix.
  • @rayokota assisted reviewing my previous PR to related code, so may be able to assist with this.
@insightfuls insightfuls requested review from a team and MSeal as code owners October 16, 2025 11:59
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ insightfuls
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@rayokota
Copy link
Member

/sem-approve

@rayokota
Copy link
Member

@insightfuls , thanks for the PR. There are some flake8 lint errors that are causing the build to fail.

@MSeal
Copy link
Contributor

MSeal commented Oct 16, 2025

We're about to get a hotfix prepared for early next week and this can be included.

@insightfuls
Copy link
Contributor Author

  • Thanks, @rayokota. I've pushed a commit to address the PEP-8 issues.
  • @MSeal, that would be fantastic if this could make a hotfix.
  • @ Everyone, I've now successfully tested this in a real environment.
@MSeal MSeal enabled auto-merge (squash) October 20, 2025 17:30
@MSeal MSeal mentioned this pull request Oct 20, 2025
2 tasks
@MSeal MSeal merged commit 8c5976e into confluentinc:master Oct 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants