Skip to content

Conversation

@stevebang
Copy link
Contributor

What

No code change, but removes comment in oauth_oidc_ccloud_producer.py file: The comment was explaining a limitation about needing to provide a CA bundle at a specific hardcoded path, but there was no actual code implementing or using that hardcoded path.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

Doc update removing hardcoded comment only.

References

JIRA:
https://confluentinc.atlassian.net/browse/DOCS-36541

Test & Review

Open questions / Follow-ups

Copilot AI review requested due to automatic review settings September 30, 2025 23:51
@stevebang stevebang requested review from a team and MSeal as code owners September 30, 2025 23:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an outdated comment that incorrectly described a hardcoded CA bundle path requirement for OAuth OIDC authentication in Confluent Cloud producer examples.

  • Removes misleading documentation about a non-existent hardcoded path requirement
  • Simplifies the comment to focus on the OAuth client credentials grant mechanism
  • Eliminates confusion about CA bundle configuration that isn't actually implemented in the code

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@stevebang stevebang changed the title DOCS-36541: Remove hardcoded param from DOCS-36541: Remove hardcoded param from OAuth example file Sep 30, 2025
@stevebang stevebang changed the title DOCS-36541: Remove hardcoded param from OAuth example file DOCS-36541: Remove comment with outdated info about hardcoded path from OAuth example file Sep 30, 2025
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes when 'sasl.oauthbearer.method': 'oidc' a callback isn't needed. It's needed without that property for a generic OAUTHBEARER implementation but the OIDC one already uses an internal implementation.

As a developer quote on behavior that this doc update reflects

@stevebang stevebang merged commit a3b43aa into master Oct 6, 2025
2 checks passed
@stevebang stevebang deleted the sbang/DOCS-36541 branch October 6, 2025 19:01
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (66.90% Estimated after merge)
  • Duplications No duplication information (4.90% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants