refactor(cli): remove duplicate code #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Sorry but --includes gives the path of external markdown files, & --includesName the name of item menu of externals markdown files |
Contributor Author
| I know, but they are duplicate. Check lines 97, 101, 129, 133 |
Contributor
| Ok sorry, can you use develop branch for the PR ? |
Contributor Author
| Done |
Contributor
| Thanks for the PR |
| This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. Why locking ? Having issues with the most up-to-date context. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This code is duplicate
https://github.com/alan-agius4/compodoc/blob/eb25e1a5fe4650e69f3b2e90c66a1280ee217ccf/src/index-cli.ts#L97
https://github.com/alan-agius4/compodoc/blob/eb25e1a5fe4650e69f3b2e90c66a1280ee217ccf/src/index-cli.ts#L101