Skip to content

Conversation

@bameyrick
Copy link
Contributor

Extends the work in #1439 to:

  • Allow for options to be provided with a default value input('value', { transform: (value) => value.toLowerCase() })
  • Allow for multiple types for inputs e.g. input<string | number>(), input<'button' | 'reset'>()

This doesn't fully address some of the comments in #1439 to use babel, however it should handle more cases for input/output/model signals.

Closes #1498

@vogloblinsky
Copy link
Contributor

Hi,
Thank for this PR.
Could you add unit tests for that in test/src/cli/cli-generation-big-app.spec.ts?
🙏🏻

@bameyrick
Copy link
Contributor Author

Hi @vogloblinsky, I've added some (admittedly very messy) tests and made sure the signal's default values/types also work with periods and underscores .

@vogloblinsky vogloblinsky merged commit 2cb2dbb into compodoc:develop Nov 12, 2024
1 of 8 checks passed
@bameyrick bameyrick deleted the input-signals-improvements branch November 12, 2024 16:43
@pvds
Copy link

pvds commented Nov 13, 2024

@bameyrick great work!

@vogloblinsky I'm not sure whether compodoc has a release schedule.
When do you plan to create a new release?

@vogloblinsky
Copy link
Contributor

I am on it, this week ;)

@pvds
Copy link

pvds commented Nov 26, 2024

@vogloblinsky I guess you're busy, any update on the release?

@valentinpalkovic
Copy link
Contributor

@vogloblinsky Any chance of getting this fix released soon? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants