- Notifications
You must be signed in to change notification settings - Fork 113
CellNetwork.cell_neighbors() modification #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2twenity wants to merge 19 commits into compas-dev:main Choose a base branch from 2twenity:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+36,103 −1
Open
Changes from all commits
Commits
Show all changes
19 commits Select commit Hold shift + click to select a range
78aa12d First version of cell neighbors search
2twenity 699c5b5 Debug things were added to the function
2twenity 15d4f03 Debug things were added to the function
2twenity c87a0c2 Some bug fixes
2twenity ce730cd Final condition of polygons intersection added. Cell neighbors pytest…
2twenity 41c5627 Polygon bug was fixed
2twenity 22a2170 Function was simplified into more bruteforce algorithm
2twenity fb087fd The mesh adjacency function was simplified to common vertices check
2twenity fe82e1d Function that adds a manifold mesh as a cell to CellNetwork was imple…
2twenity 760c5c8 Cell neighbors function fixed
2twenity 697665d Cell Neighbors function bug fixed
2twenity da4b248 Cell Neighbor function bug fixes
2twenity e816686 Cell Neighbors function test added
2twenity b45e7ca Cell Neighbors test modified
2twenity 5e86329 Cell Neighbours test commented out
2twenity b3f2f0e Some adjustments
2twenity 7bf234c Reviewd changes applied
2twenity 246a7c1 Merge branch 'compas-dev:main' into main
2twenity bfea5c9 Merge branch 'compas-dev:main' into main
2twenity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have the felling this already exists but under a different name, no @romanarust ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this does not yet exist