Skip to content

Integrating discussion landing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2020
Merged

Integrating discussion landing #12

merged 5 commits into from
Jul 12, 2020

Conversation

@DevanshCodes
Copy link
Member

@DevanshCodes DevanshCodes commented Jun 24, 2020 •
edited
Loading

Features Added:

  • Separate Pages for each topic Discussion.

  • Single Page website, with component Discussion

  • Everything is being read from JSON

  • Added the Reply feature
@DevanshCodes DevanshCodes linked an issue Jun 24, 2020 that may be closed by this pull request
Integrating Discussion and Landing Page #11
Closed
@DevanshCodes
Copy link
Member Author

@ayushnagar123
@DevanshCodes DevanshCodes force-pushed the integrating-discussion-landing branch from f1c5103 to 0699564 Compare June 27, 2020 14:15
ayushnagar123
ayushnagar123 suggested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@ayushnagar123 ayushnagar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Errors while render of each page must be handled.
src/components/sidebar/sidebar.scss
bottom: 0;
left: 0;
min-height: 93.5vh;
min-height: 92.5vh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. need to fix the hight issue the height of the navbar looks in appropriate.
    image

  2. Navbar content overlaps below 1050px. Responsiveness needs to be taken into handle.
    image
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool will work on that!
@DevanshCodes
Copy link
Member Author

Fixed all issues, just that error of unique key is left, I'll fix that in my other PR coz this will cause huge merging error in my new PR which is already there.
Ready for merging.
@DevanshCodes DevanshCodes merged commit 8df896c into codeuino:development Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@DevanshCodes @ayushnagar123