[WIP]: Add extension install logic to vscode-desktop-core #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Add logic for handling VS Code and non-MS IDEs in scripts. - Introduce Terraform variables for extension details. - Implement validation for protocol selection. - Include tests to validate extension install paths and mutual exclusions.
There was a problem hiding this comment.
Pull Request Overview
This PR adds extension installation functionality to the vscode-desktop-core Terraform module, enabling automatic installation of IDE extensions via either extension IDs (normal operation) or direct URLs (airgapped environments).
Key changes:
- Adds new variables for managing extensions:
extensions,extensions_urls, andextensions_dir - Implements a bash script (
run.sh) that downloads and installs extensions from marketplace URLs - Adds validation to prevent simultaneous use of both extension installation methods
- Updates minimum Coder provider version to 2.11
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.tf | Adds extension-related variables, default extensions directories mapping, coder_script resource for extension installation, and protocol validation |
| run.sh | New bash script implementing extension download/installation logic with marketplace URL generation for different IDE types |
| main.test.ts | Adds comprehensive test coverage for extension installation script generation and marketplace logic |
| vscode-desktop-core.tftest.hcl | Adds Terraform tests for extensions directory defaults, custom overrides, and validation scenarios |
…thods, and add module dir with logging paths for troubleshooting
…process with detailed output for troubleshooting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
WIP