Skip to content

Conversation

@blink-so
Copy link
Contributor

@blink-so blink-so bot commented Aug 23, 2025

Simplify author mention logic in release changelog generation:

  • Always use .author.login from the commit API when building the changelog entries
  • Remove fallback to .commit.author.name to avoid invalid @ mentions when only a name is available

Rationale: All commits land via PRs that are linked to GitHub users, so .author.login should always be available.

Test plan:

  • Exercised on local branch by reading workflow; minimal risk as behavior matches expectation where author is a GH user.

If any commit ever lacks .author.login, the entry would produce an empty mention; but given our policy this should not occur.

Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
@matifali matifali closed this Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant