Skip to content

fix: option can not be an empty string #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

fix: option can not be an empty string #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c96046
fix: option can not be an empty string
brettkolodny Jun 13, 2025
ce34d6b
fix: allow empty string
brettkolodny Jun 13, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/client/components/DynamicParameter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,8 @@ const ParameterField: FC<ParameterFieldProps> = ({
case "dropdown":
return (
<Select
onValueChange={onChange}
value={value}
onValueChange={(v) => onChange(v.substring(5))}
value={`data-${value}`}
disabled={disabled}
required={parameter.required}
>
Expand All @@ -392,7 +392,10 @@ const ParameterField: FC<ParameterFieldProps> = ({
</SelectTrigger>
<SelectContent>
{parameter.options.map((option) => (
<SelectItem key={option.value.value} value={option.value.value}>
<SelectItem
key={option.value.value}
value={`data-${option.value.value}`}
>
<OptionDisplay option={option} />
</SelectItem>
))}
Expand Down Expand Up @@ -487,9 +490,11 @@ const ParameterField: FC<ParameterFieldProps> = ({
case "radio":
return (
<RadioGroup
onValueChange={onChange}
onValueChange={(v) => {
onChange(v.substring(5));
}}
disabled={disabled}
value={value}
value={`data-${value}`}
className="relative"
>
{parameter.options.map((option) => (
Expand All @@ -499,7 +504,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
>
<RadioGroupItem
id={`${id}-${option.value.value}`}
value={option.value.value}
value={`data-${option.value.value}`}
/>
<Label
htmlFor={`${id}-${option.value.value}`}
Expand Down