Skip to content

feat: re-render parameters on all changes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

feat: re-render parameters on all changes #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/client/Preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,9 @@ type FormProps = { parameters: ParameterWithSource[] };
const Form: FC<FormProps> = ({ parameters }) => {
return parameters
.sort((a, b) => a.order - b.order)
.map((p, index) => <FormElement key={index} parameter={p} />);
// Since the form is sourced from constantly changing terraform, we are not sure
// if the parameters are the "same" as the previous render.
.map((p) => <FormElement key={window.crypto.randomUUID()} parameter={p} />);
};

type FormElementProps = { parameter: ParameterWithSource };
Expand All @@ -542,9 +544,7 @@ const FormElement: FC<FormElementProps> = ({ parameter }) => {
const value = useMemo(
() =>
$form[parameter.name] ??
(parameter.default_value.value === "??"
? ""
: parameter.default_value.value),
undefined,
[$form, parameter],
);

Expand Down