Feature/local storage cache #33
Merged
+108 −59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
code-asher requested changes Dec 21, 2023
Makes the description more precise, as there's no separate handling of manifest. Co-authored-by: Asher <ash@coder.com>
| Released in v2.1.0. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a cache to extensions read from the file system, similar to the one used for extensions read from an Artifactory repository.
My use case is that i have many (6000+) extensions with different versions on disk, and walking through all of them takes upwards of 3 minutes for every single API call. With a cache in place, I can instead pre-fill the cache at regular time intervals, and respond to API calls within ~300 milliseconds.
I have tried to emulate the existing code style with my changes, but my Go skills are admittedly a bit rusty, so I welcome any feedback, and will try to make changes as best I can.
This PR also does not address the issue of evicting the cache on adding/removing extensions that has been noted in a TODO in the Artifactory implementation, but hopefully that can be tackled as a future improvement.