This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Add user-specified base address to pointer mapper #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If the base address of the pointer mapper is 1, various tools will complain about alignment, even though these are not "real" pointers. Changing it to a user-specified variable, with a default highly-aligned value, should fix this problem.
Ruyk suggested changes Aug 23, 2017
utils/vptr/include/virtual_ptr.hpp Outdated
| PointerMapper(base_ptr_t baseAddress = 4096) | ||
| : m_pointerMap{}, m_freeList{}, m_baseAddress{baseAddress} { | ||
| if (m_baseAddress == 0) { | ||
| throw std::out_of_range(std::string("Base address cannot be zero")); |
There was a problem hiding this comment.
I would say an std::invalid_argument is more relevant
There was a problem hiding this comment.
You're too right! I actually went onto cppreference, looked at the exceptions, thought to myself "this is invalid arg!" and wrote out of range because I'm a damn fool. Thanks!
jwlawson approved these changes Aug 23, 2017
Ruyk approved these changes Aug 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If the base address of the pointer mapper is 1, various tools will
complain about alignment, even though these are not "real" pointers.
Changing it to a user-specified variable, with a default highly-aligned
value, should fix this problem.