This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Niceify simple_private_memory and fix comments on it #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
keryell reviewed Jul 6, 2017
| cl::sycl::id<1> lID = item.get(); | ||
| return cl::sycl::id<1>(group.get(0) * localR.get(0) + lID.get(0)); | ||
| cl::sycl::id<1> localID = item.get(); | ||
| return cl::sycl::id<1>(groupID.get(0) * localR.get(0) + localID.get(0)); |
There was a problem hiding this comment.
All these types are actually useles if you use auto... :-)
Auto-nice-ifying is the way to go to avoid these kinds of errors...
| /* We create a linear (one dimensional) group range, which | ||
| * creates a thread per element of the vector. */ | ||
| * creates a work-item per element of the vector. */ | ||
| auto groupRange = range<1>(nItems / nLocals); |
There was a problem hiding this comment.
You can even replace all the () by {} in the constructors to be nicer and more modern.
| | ||
| /* Helper function to compute a globalID from a group and item in a | ||
| * hierarchical parallel_for_work_item context */ | ||
| static inline cl::sycl::id<1> get_global_id(cl::sycl::group<1>& group, |
There was a problem hiding this comment.
Is this a missing function from the specification?
There was a problem hiding this comment.
Yes, it is, and we have sent feedback to the Khronos group.
There was a problem hiding this comment.
Oh yes, I remember and Victor worked on this. I put this into triSYCL long time ago because it was obvious to me it was forgotten from the spec... :-(
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.