This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Change virtual pointer to use vptr namespace instead of cl::sycl::codeplay namespace #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The DPC++ nightly generates errors due to the cl::sycl namespace used for virtual pointers. To avoid this issue, this patch uses the SYCL-2020 ::sycl namespace for DPC++.
The namespace has been changed since using the cl::sycl:: namespace like this may not be compatible with all SYCL implementations. * Changes cl::sycl::computecpp to vptr * Update tests and samples
DuncanMcBain approved these changes Sep 20, 2022
ProGTX approved these changes Sep 21, 2022
hjabird changed the title Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The vptr class is used in SYCL-BLAS. We want to be able to compile SYCL-BLAS using DPC++. The latest DPC++ nightlies generates errors due to the cl::sycl namespace used for virtual pointers. To avoid this issue, this patch uses the SYCL-2020 ::sycl namespace for DPC++.