This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Update CMake version to version 3.10.2 #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DuncanMcBain force-pushed the cmake-updates-3102 branch from f8c26ca to a716aa5 Compare 
This version comes with Ubuntu 18.04, and allows us to remove some legacy OpenMP code. We are also better about dealing with some policies that were introduced in newer CMake versions that are hit by our code.
They were required in an older version of CMake, but now we can expand the generator expressions directly inside the custom command, ensuring that they are up-to-date with any subsequent include directories or definitions.
DuncanMcBain force-pushed the cmake-updates-3102 branch from a716aa5 to d5b7559 Compare 
| I would like to merge this because it is now blocking #283 as that sample needs to set a different CXX standard to the rest of the samples |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This version comes with Ubuntu 18.04, and allows us to remove some
legacy OpenMP code. We are also better about dealing with some
policies that were introduced in newer CMake versions that are hit
by our code.