This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Cmake dependency fix #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 11 commits October 12, 2016 16:01
This patch adds some licensing and documentation information for the FindComputeCpp module in order to easily re-distribute the FindComputeCpp file without the rest of the SDK.
* Host matrix multiplication deals with non-divisible sizes of matrix * SYCL variant only accepts power-of-two matrix sizes * Error correction is added to both host and sycl variants
* Clang-format matrix multiply * Added missing std:: to min
* Removed extra ;
The device compiler generation of the stub file was not properly triggered when there were changes associated with files other than the source file. This caused the device compiler to not be triggered when related files, such as included files, were modified, therefore using an incorrect integration header. This patch fixes the DEPENDS clause of the add_custom_command so that it points to the actual source file inependently of the working directory, and also forces Cmake to trigger the dependency scanning for the source file.
DuncanMcBain approved these changes Apr 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The device compiler generation of the stub file was not properly
triggered when there were changes associated with files other than
the source file.
This caused the device compiler to not be triggered when related files,
such as included files, were modified, therefore using an incorrect
integration header.
This patch fixes the DEPENDS clause of the add_custom_command so that
it points to the actual source file inependently of the working
directory, and also forces Cmake to trigger the dependency scanning for
the source file.