Skip to content

Conversation

@soderlind
Copy link

Should fix #15

@soderlind
Copy link
Author

The failed checks are not because of my change, please view the error log at CircleCI

@josephdpurcell
Copy link
Contributor

I believe rebasing on master will fix the test failures shown in the latest pass.

I have created a similar PR #31 for Drupal. Perhaps we can standardize on a similar approach? I like the idea of having separate RUN statements.

One thing you may need to add is the list of sniffs in Sniffs.php, otherwise I believe it throws an error. You should be able to generate the list of sniffs with phpcs -e --standard="WordPress,WordPress-Core,WordPress-Docs,WordPress-Extra,WordPress-VIP"

@josephdpurcell
Copy link
Contributor

I believe #34 deprecates the need for this PR.

@dblandin
Copy link
Contributor

dblandin commented Jun 9, 2016

Hey @soderlind,

We ended up taking a different route here via a composer dependency in #34. Thanks for this PR and enjoy the Wordpress checks! They're available now via the CLI and we should have this out to codeclimate.com sometime tomorrow.

Thanks!

@dblandin dblandin closed this Jun 9, 2016
@dblandin
Copy link
Contributor

dblandin commented Jun 9, 2016

Hey @soderlind,

Just wanted to follow up and let you know that we've released a new engine image to codeclimate.com with the new Wordpress coding standards.

You can enable the standards today by updating your codeclimate.yml configuration file:

phpcodesniffer: enabled: true config: standard: "Wordpress"

The full list of supported standards is now available in our README.

Thanks for the nudge on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants