Skip to content

Conversation

@richardbrinkman
Copy link
Contributor

This PR solves the E_DEPRECATED errors such as:

Caxy\\HtmlDiff\\HtmlDiffConfig::setCacheProvider(): Implicitly marking parameter $cacheProvider as nullable is deprecated, the explicit nullable type must be used instead 

in file caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiffConfig.php

See also https://www.php.net/manual/en/migration84.deprecated.php

After merging this PR, please make a new release as well, such that users of composer can update easily.

Copy link
Member

@jschroed91 jschroed91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request, friend!

@jschroed91 jschroed91 merged commit 5c580b4 into caxy:master Jan 22, 2025
1 check passed
christian-kolb pushed a commit to vera-contracts/php-htmldiff that referenced this pull request Mar 21, 2025
Co-authored-by: Richard Brinkman <r.brinkman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants