Configurable functional tests #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SavageTiger force-pushed the sven/feature/test_config_flag branch 4 times, most recently from c5118ca to 42dfc4c Compare In order to test scenario's that effect the output when a configuration flag is set I added the ability to configure what config should be affected on a per functional test basis.
In preperation of rewriting convertHtmlToListOfWords I added a test to check if the keepNewLines feature still works as expected afterwards.
SavageTiger force-pushed the sven/feature/test_config_flag branch from 42dfc4c to ba5428c Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
In preparation for rewriting the convertHtmlToListOfWords() method I added the ability to apply configure flags to the functional tests.
This way its possible to set custom config flags, and test the effects of those config flags on the output.
I added the test scenario to this PR for the keep-new-lines feature, to make sure it still works after the rewrite.