This repository was archived by the owner on Oct 24, 2020. It is now read-only.
Configure for Unix.map_file / Bigarray.Genarray.map_file #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
c-cube reviewed Oct 9, 2019
c-cube reviewed Oct 9, 2019
c-cube suggested changes Oct 9, 2019
Owner
c-cube left a comment
c-cube left a comment There was a problem hiding this comment.
Really good contribution, thank you. Just a few comments 👍 .
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add compatibility for new OCaml releases where
map_filehas moved to theUnixmodule and specialisedBigarray.Array[123]variants have been removed.Stay compatible with older OCaml releases.