fixed oauth uri construction to correctly handle additional params (#… #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lazysasha commented Jul 19, 2020
lazysasha commented - Closes OauthAuthorizationUri creates incorrect URL #126: Fixed oauth uri construction with additional params
- Tested
This was referenced Aug 13, 2020
| Hi @lazysasha, Thank you so much for creating this fix! 🙏🏼 Unfortunately, as you created the PR from a forked repository, I couldn't make some required changes. However, I have given you all the credit in the new PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.