Semi-fix: custom rooms #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a semi-fix for #37, which change the structure of the
Base.gamemodesobject. That property no longer exists and instead we have to use Base.rooms, which is an array of rooms. When the server restarts, there's only one room: FFA. Its ID isffa(case-sensitive). Rooms can be pushed to the array, but there is no way to interact with it.To access member properties of it we use ES6' Array function
findand pass a callback function to it, which searches for an object in that array where its ID equals toffa.For object references in arrays you can use the [] operator and get the index with
Array.prototype.findIndex.