Skip to content

Memory leak and take data object in SessionIDManager#deleteSession #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Memory leak and take data object in SessionIDManager#deleteSession #5

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e49b76f
Delete by username
y21 Jun 25, 2018
4be2a5b
Update JSDocs and fix memory leak (use data obj)
y21 Jun 25, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update JSDocs and fix memory leak (use data obj)
  • Loading branch information
@y21
y21 authored Jun 25, 2018
commit 4be2a5bda055cfa31aa69999603b73b69c81a243
28 changes: 21 additions & 7 deletions backend/SessionIDManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,30 @@ exports.generateSessionID = length => {
* Deletes a session id from database
*
* @param {object} database The database object
* @param {string} session The session id
* @returns {promise<string>} The deleted session id
* @param {string} data An object with both a type property (search keyword, either: session, username or expiresAt) and a value property
* @returns {promise<string>} The provided value
*/
exports.deleteSession = (database, session) => {
exports.deleteSession = (database, data) => {
return new Promise((resolve, reject) => {
try {
database.prepare("SELECT * FROM sessionids WHERE sessionid = ?").then(prepare => {
prepare.run([session]).then(() => resolve(session)).catch(reject);
}).catch(reject);
} catch(e){
switch (data.type) {
case "session":
database.prepare("DELETE FROM sessionids WHERE sessionid = ?").then(prepare => {
prepare.run([data.value]).then(() => resolve(data.value)).catch(reject);
}).catch(reject);
break;
case "username":
database.prepare("DELETE FROM sessionids WHERE username = ?").then(prepare => {
prepare.run([data.value]).then(() => resolve(data.value)).catch(reject);
}).catch(reject);
break;
case "expiresAt":
database.prepare("DELETE FROM sessionids WHERE expires = ?").then(prepare => {
prepare.run([data.value]).then(() => resolve(data.value)).catch(reject);
}).catch(reject);
break;
}
} catch (e) {
reject(e);
}
});
Expand Down