Skip to content

Conversation

hvdthong
Copy link
Contributor

@hvdthong hvdthong commented May 8, 2024

Hi @terryyz , can you please help check my files (76 files in total)? Many thanks in advance and have a great evening.

All the best,
James Hoang


def f_3747(data, date_format, country, country_codes=None):
"""
Draw a histogram of the data from a DataFrame column of the pandas after converting the data into a specific format and locale,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please specify the 'dates' column name


def f_3345(image_path='image.jpg', histogram_path='histogram.png'):
"""
Read an image, create a histogram of the image pixel intensities, save the histogram as a PNG file,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention the possible size, as you use cv2.calcHist([img], [0], None, [256], [0, 256])


Returns:
- dict: A dictionary with mean and standard deviation of each column.
- matplotlib.figure.Figure: The figure object containing the bar chart.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention the axis names and title names

import numpy as np

class TestCases(unittest.TestCase):
@classmethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do setup/teardown methods, don't do class

@terryyz
Copy link
Collaborator

terryyz commented May 8, 2024

close this PR for now

@terryyz terryyz closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants