Skip to content

Conversation

@rlymbur
Copy link
Contributor

@rlymbur rlymbur commented Feb 5, 2025

What type of PR is this?
Bug

Which issue does this PR fix:
#673

What does this PR do / Why do we need it:
Increases timeout on E2E tests and adds a custom retryer to address these failures.

Testing done on this change:

make e2e-test ... Ran 69 of 69 Specs in 3036.131 seconds SUCCESS! -- 69 Passed | 0 Failed | 0 Pending | 0 Skipped --- PASS: TestIntegration (3036.14s) PASS ok github.com/aws/aws-application-networking-k8s/test/suites/integration 3036.770s 

Automation added to e2e:

N/A

Will this PR introduce any new dependencies?:

No.

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No.

Does this PR introduce any user-facing change?:

No.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rlymbur rlymbur added the bug Something isn't working label Feb 5, 2025
@rlymbur rlymbur enabled auto-merge (squash) February 5, 2025 00:11
Copy link
Contributor

@erikfuller erikfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this. Really just my one question around the retryer code to address before moving ahead.

@rlymbur rlymbur requested a review from erikfuller February 6, 2025 00:17
Copy link

@iph iph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a clarifying question around amount of retries but that's about it.

MinRetryDelay: 1 * time.Second,
MaxThrottleDelay: 5 * time.Second,
MaxRetryDelay: 5 * time.Second,
NumMaxRetries: 3,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the default retries we are overriding?

I get that these are integration tests -- but 3 is "quite a bit".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default retries is actually already three, probably best I remove it here to avoid any confusion. For some more context:

const (	// DefaultRetryerMaxNumRetries sets maximum number of retries	DefaultRetryerMaxNumRetries = 3	// DefaultRetryerMinRetryDelay sets minimum retry delay	DefaultRetryerMinRetryDelay = 30 * time.Millisecond	// DefaultRetryerMinThrottleDelay sets minimum delay when throttled	DefaultRetryerMinThrottleDelay = 500 * time.Millisecond	// DefaultRetryerMaxRetryDelay sets maximum retry delay	DefaultRetryerMaxRetryDelay = 300 * time.Second	// DefaultRetryerMaxThrottleDelay sets maximum delay when throttled	DefaultRetryerMaxThrottleDelay = 300 * time.Second ) 
Copy link
Contributor

@mikestvz mikestvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rlymbur rlymbur dismissed erikfuller’s stale review February 6, 2025 18:49

Issue addressed

@rlymbur rlymbur merged commit 6b14571 into aws:main Feb 6, 2025
2 checks passed
@rlymbur rlymbur deleted the 673 branch February 6, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

4 participants