Zombie burying ritual #1264
Open
Zombie burying ritual #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Forgetting it here is premature, and will leak the server process. Instead, let on_server_crash() handle the cleanup & deal with zombies.
The extra-verbose dumps of pages and pages of user-generated data *per message* simply don't belong at INFO loglevel, killing it's usability.
ulidtko added a commit to ulidtko/versioned-configs that referenced this pull request Mar 6, 2024
ulidtko added a commit to ulidtko/versioned-configs that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've noticed LanguageClient-neovim accumulates zombies on LSP-server restarts... 👻
Classically, whenever that happens — it means the parent process doesn't respect its duty to at least read out the exit-code of children processes that die.
Here's a fix by means of keeping track of the spawned
Childprocess instead of itsu32PID. IIRC, it wasn't possible to construct aChildfrom bare PID for thatchild.try_wait()call. See code.