Raise the BufWriter capacity to avoid blocking on writes #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
At least for me, vim's ui blocks when using a single threaded language server that works for a long time before reading the next command from stdin. With phan, I see the editor does not seem to block with this patch. See https://doc.rust-lang.org/std/io/struct.BufWriter.html#implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
At least for me, vim's ui blocks when using a single threaded language
server that works for a long time before reading the next command from
stdin.
With phan, I see the editor does not seem to block with this patch.
See
https://doc.rust-lang.org/std/io/struct.BufWriter.html#implementations