This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Fix Node debugging by catching warning #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following up on #804
Fixes the debugger which causes the .NET Core app to crash due to a Node warning.
Unfortunately it's hard to make this really future proof, because the wording and structure of the warnings regarding debugging could easily change in future versions. I still think it would be nice to be able to treat all warnings from Node differently from errors, but no idea how to approach that. Cause for a separate discussion I suppose.