Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@stephtr
Copy link
Contributor

@stephtr stephtr commented May 4, 2017

The React templates used any and void as State and Property types for React.Component, even though it should be {}.

@dnfclas
Copy link

dnfclas commented May 4, 2017

@stephtr,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@SteveSandersonMS SteveSandersonMS merged commit f2260d5 into aspnet:dev May 5, 2017
@SteveSandersonMS
Copy link
Member

Thanks @stephtr - this looks good!

@antmdvs
Copy link

antmdvs commented May 11, 2017

@stephtr Why was void considered incorrect? Just curious. Thanks!

@stephtr
Copy link
Contributor Author

stephtr commented May 11, 2017

That question was best answered in TypeScript #15409: props is always an object, even without properties.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants