Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@Gimly
Copy link

@Gimly Gimly commented Jan 9, 2017

I figured out what was causing the issue that I had opened in #534. It was not really linked to Angular or anything as the error message could suggest, but to the publishing process.

I'm publishing my app through Bitbucket Pipelines that runs a script in a Docker image to create a CI/CD system. The script I was using was simply running dotnet restore and then dotnet publish. What I hadn't seen was that dotnet publish-iis that is called by the post publish methods was failing. It was failing because on the docker image I'm using (microsoft/aspnetcore-build) only the .Net Core 1.1 is installed. The issue was that there were still tools dependencies in the project.json file that were depending on .Net Core 1.0, and running those tools were making the publish-iis fail.

Using the latest 1.1.0-preview4-final versions of

  • Microsoft.AspNetCore.Razor.Tools
  • Microsoft.AspNetCore.Server.IISIntegration.Tools
  • Microsoft.DotNet.Watcher.Tools

fixes the issue and makes the all publish work correctly on the docker machine.

There were still tools dependencies in the project.json file that were depending on .Net Core 1.0. This means that on a machine with only .Net Core 1.1 installed (like the microsoft/aspnetcore-build docker image) the `dotnet publish-iis` command would fail because it was trying to find .Net Core 1.0. Using the latest 1.1.0-preview4-final versions of - Microsoft.AspNetCore.Razor.Tools - Microsoft.AspNetCore.Server.IISIntegration.Tools - Microsoft.DotNet.Watcher.Tools fixes the issue and makes the all publish work correctly on the docker machine.
@dnfclas
Copy link

dnfclas commented Jan 9, 2017

Hi @Gimly, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Jan 9, 2017

@Gimly, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@Gimly
Copy link
Author

Gimly commented Feb 4, 2017

Hello,

Is there something wrong with this pull request? Do you want me to fix something?

Regards

@RichiCoder1
Copy link

According to #684 this might be rendered redundant. AspNet peeps are probably in fire mode with VS RTM coming down the pipeline. /cc @natemcmaster

@SteveSandersonMS
Copy link
Member

@Gimly Sorry this is taking a while to merge and for not commenting so far. Thanks for this contribution.

We're just working through transitioning everything in this repo to csproj-based tooling. Once that is done, some parts of this PR will still apply (the bits in the templates), and some parts will not (the bits in the samples). If we are retaining support for generating project.json-based projects, I'll then merge in the relevant parts of this PR. Hope that's OK!

@Gimly
Copy link
Author

Gimly commented Feb 22, 2017

@SteveSandersonMS No problem! I was just wondering if there was something I could improve in the PR that was blocking your from merging. I completely understand that you're merging to the csproj-based tooling and that it has an impact.

@SteveSandersonMS
Copy link
Member

Again, sorry this has taken a while to get to.

Now that dotnet's 1.0 csproj tooling has shipped, we'll shortly be pulling out the project.json vestiges from here. Obviously people who already have project.json-based projects can continue with them for as long as they want, but it doesn't really make sense for us to be shipping and maintaining tools to create new project.json-based projects. Newly-created projects should be csproj-based.

As such, the changes in this PR (which would have otherwise been valuable) will not be applicable any more. So to keep things tidy, I'll close this now.

Again, thanks for contributing this and for bearing with us while we make the transition to 1.0.0 tooling!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants