Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@scottaddie
Copy link
Member

Addresses issue #444 by explicitly adding a -loader suffix to all Webpack loader references.

@dnfclas
Copy link

dnfclas commented Nov 19, 2016

Hi @scottaddie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@SteveSandersonMS
Copy link
Member

Thanks for this @scottaddie!

Unfortunately it looks like the changes here are based on quite an old version of the JavaScriptServices code. For example, it still has the .dev.js/.prod.js files, which no longer exist in the latest code.

Would it be possible for you to make the changes based on the latest JavaScriptServices commit? The easiest way might be for you to close this PR and open a new one.

@scottaddie
Copy link
Member Author

Oops! I was using the master branch instead of dev. I'll take care of it later today.

@scottaddie scottaddie closed this Nov 19, 2016
@scottaddie scottaddie deleted the explicit_loader_suffix branch November 19, 2016 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants