Don't use depricated constructor

[ryanbrandenburg]

Fixes #1668.

All the whitespace stuff was done by VSCode, but it appears to be correct to me, so I'm not going to fight it unless @SteveSandersonMS objects.

[SteveSandersonMS]

The code changes look good.

All the whitespace stuff was done VSCode

The .js file is from the build output, so ideally what we commit to Git should be whatever the builds outputs (not what VS Code does to reformat it). If we commit the VSCode-reformatted version, then it will look like a huge load of changes occurred every time we rebuild.

BTW I appreciate it's unusual to commit build output like this. The reason it was done originally is that it was a small file and it was useful to verify the .js diffs manually to be sure that newer versions of the TS compiler or Webpack (etc) didn't change it in unexpected ways. If you want we could change it so the .js file is only produced during the CI build, but TBH the amount of benefit from doing that change would be minimal.

[ryanbrandenburg]

What is src/Microsoft.AspNetCore.NodeServices.Sockets/Content/Node/entrypoint-socket.js generated from? How can I re-generate it to ensure it's all correct?

[ryanbrandenburg]

I would prefer that we test generated code for functionality rather than check it in to examine diffs. But for now we should at least make it a little clearer what parts of the code are generated.

[ryanbrandenburg]

@SteveSandersonMS we need answers to the above questions before we make progress on this work.

[SteveSandersonMS]

@ryanbrandenburg The NodeServices/NodeServices.Sockets/SpaServices projects all contain TypeScript code that gets built following typical NPM/Webpack conventions. If you check the package.json files in those directories, you'll see they all include scripts config entries similar to:

 "scripts": { "build": "... some command involving webpack ..." }, 

This implies you can run the webpack build by using the following commands:

cd [that directory containing package.json] npm install npm run build 

In the webpack.config.js files, each of these projects is configured to place its Webpack build output in ./Content/Node (see the output section of the config). So, that's the subdirectory whose content is generated.

Note

The Webpack build configs currently in master assume you're using relatively old versions of Webpack and TypeScript. I just checked, and due to changes in Webpack and TypeScript, the Webpack build actually fails if you update to the latest Webpack/TypeScript. Since there's no good reason to require the use of older versions of Webpack/TypeScript, I've just submitted PR #1748 which updates all this build config to the latest Webpack/TypeScript. I recommend we merge this before you attempt to actually use the Webpack builds, otherwise you'll probably get errors.

[ryanbrandenburg]

@SteveSandersonMS when I re-generated there seemed to be a lot of un-related changes. Did I do it right or did we not re-generate a couple times before this?

[SteveSandersonMS]

Looks like the unrelated changes are just whitespace, which is fine. Is it possible that you got VS to reformat the files again? If not I’m not sure why the whitespace diff is there. In any case it won’t be a problem.

[ryanbrandenburg]

Re(Re)-generating didn't show any difference between the two, so I assume it's just a difference in TypeScript compilation. Will merge once branches are open.