Update templates to support TypeScript's strict mode #1113
Conversation
| if (module['hot']) { | ||
| module['hot'].accept(); | ||
| module['hot'].dispose(() => { | ||
| if (module.hot) { |
There was a problem hiding this comment.
used node's definition, switched to webpack's
| | ||
| // Create browser history to use in the Redux store | ||
| const baseUrl = document.getElementsByTagName('base')[0].getAttribute('href'); | ||
| const baseUrl = document.getElementsByTagName('base')[0].getAttribute('href')!; |
There was a problem hiding this comment.
When we assume that a base element exists, we can also assume that it has the href attribute set.
| // This code starts up the React app when it runs in a browser. It sets up the routing | ||
| // configuration and injects the app into a DOM element. | ||
| const baseUrl = document.getElementsByTagName('base')[0].getAttribute('href'); | ||
| const baseUrl = document.getElementsByTagName('base')[0].getAttribute('href')!; |
There was a problem hiding this comment.
When we assume that a base element exists, we can also assume that it has the href attribute set.
| private renderPagination() { | ||
| let prevStartDateIndex = this.props.startDateIndex - 5; | ||
| let nextStartDateIndex = this.props.startDateIndex + 5; | ||
| let prevStartDateIndex = (this.props.startDateIndex || 0) - 5; |
There was a problem hiding this comment.
Usually startDateIndex gets set in componentWillMount by calling requestWeatherForecasts.
| | ||
| return platformDynamicServer(providers).bootstrapModule(AppModule).then(moduleRef => { | ||
| const appRef = moduleRef.injector.get(ApplicationRef); | ||
| const appRef: ApplicationRef = moduleRef.injector.get(ApplicationRef); |
There was a problem hiding this comment.
Probably because ApplicationRef is an abstract class this type wasn't inferred automatically.
| Thanks very much! This is great. It's now merged. I also turned on |
3 participants
Would fix #1098 and all other templates.
Additionally I switched from
requirejsandnodedefinitions towebpack-env, which was used by the React templates and I think is the correct solution.The Angular template still has an (external) error angular/#17863 remaining (only when compiling with strict flag).