This repository was archived by the owner on Nov 20, 2018. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork 191
Adds PipeWriterAdapter #1065
Merged
Merged
Adds PipeWriterAdapter #1065
Changes from 1 commit
Commits
Show all changes
26 commits Select commit Hold shift + click to select a range
37c509f Implement PipeWriterAdapter
jkotalik 27ee6b6 Feedback:
jkotalik d67777e Feedback:
jkotalik 3be99d5 tests and profile
jkotalik e4fa58d Good amount of feedback
jkotalik 3db542d More changes and realizing my writing was incorrect
jkotalik e41863b Feedback:
jkotalik 1f1f418 Consolidate tests into single file
jkotalik 6b90c5e Ended up not needing the obob case
jkotalik f9a23ce More tests and renaming test/benchmark files
jkotalik 07551b7 Update to use MemoryPool
jkotalik 658ff2b Revert Memory Changes
jkotalik 263504f Use MemoryPool
jkotalik 8455dcb remove nullable check for now
jkotalik 6f77267 Update cts logic
jkotalik ac0d576 Fb
jkotalik 878bec2 fix data race
jkotalik b5e2c65 cleanup
jkotalik 7bf5f2c Make memory pool plugable
jkotalik 00b6325 Feedback:
jkotalik 92d02dc Remove async
jkotalik 6d21200 Feedback
jkotalik e0eabec Feedback
jkotalik 4305011 Add test memory pool, call Complete from Dispose
jkotalik 7d1bef1 nits
jkotalik 28fd0d1 fix test
jkotalik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove async
- Loading branch information
commit 92d02dcb4bcc9af18cac6ad5207473a3363c40cf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For next PR: this is slow and we don't have a benchmark that exercises this code path at all.