more explicit constraints on MPI plane size (#12) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fangchangma approved these changes Aug 19, 2022
fangchangma left a comment
fangchangma left a comment There was a problem hiding this comment.
Minor suggestion on removing the deprecated code. Feel free to merge after the removal.
gmpi/utils/mpi_utils.py Outdated
Comment on lines 689 to 702
| # # [Deprecated] we choose four courners and middle points of four edges. | ||
| # # NOTE: the following heuristic camera positions cannot handle some extreme cases. | ||
| # # We choose to denstly sample camera positions instead. | ||
| # cam_heuristic_angles = [ | ||
| # (cam_horizontal_min, cam_vertical_min), | ||
| # (cam_horizontal_min, cam_vertical_max), | ||
| # (cam_horizontal_max, cam_vertical_min), | ||
| # (cam_horizontal_max, cam_vertical_max), | ||
| # (horizontal_mid_angle, cam_vertical_min), | ||
| # (horizontal_mid_angle, cam_vertical_max), | ||
| # (cam_horizontal_min, vertical_mid_angle), | ||
| # (cam_horizontal_max, vertical_mid_angle), | ||
| # (horizontal_mid_angle, vertical_mid_angle), | ||
| # ] |
There was a problem hiding this comment.
I suggest removing these deprecated code.
gmpi/utils/mpi_utils.py Outdated
Comment on lines 839 to 852
| # # [Deprecated] we choose four courners and middle points of four edges. | ||
| # # NOTE: the following heuristic camera positions cannot handle some extreme cases. | ||
| # # We choose to denstly sample camera positions instead. | ||
| # cam_heuristic_angles = [ | ||
| # (cam_horizontal_min, cam_vertical_min), | ||
| # (cam_horizontal_min, cam_vertical_max), | ||
| # (cam_horizontal_max, cam_vertical_min), | ||
| # (cam_horizontal_max, cam_vertical_max), | ||
| # (horizontal_mid_angle, cam_vertical_min), | ||
| # (horizontal_mid_angle, cam_vertical_max), | ||
| # (cam_horizontal_min, vertical_mid_angle), | ||
| # (cam_horizontal_max, vertical_mid_angle), | ||
| # (horizontal_mid_angle, vertical_mid_angle), | ||
| # ] |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds more explicit constraints on MPI plane sizes. Due to MPI's intrinsic properties, it may not be able to handle large range of camera poses (see #12). We add
assertionto give clearer error message.