Skip to content

Conversation

@amotl
Copy link
Contributor

@amotl amotl commented Jan 13, 2021

Hi Ivelin,

this is just a humble attempt to check whether it might be able to solve #46 already.

With kind regards,
Andreas.

@commit-lint
Copy link

commit-lint bot commented Jan 13, 2021

Bug Fixes

  • Attempt to make the CI build work on Python 3.9 (d469f27)

Contributors

amotl

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR
@amotl amotl marked this pull request as ready for review January 13, 2021 02:31
@amotl
Copy link
Contributor Author

amotl commented Jan 13, 2021

I don't know why commit-lint-pr fails on my commit. Maybe you can give me a clue?

@ivelin
Copy link
Contributor

ivelin commented Jan 14, 2021

Very cool. Thank you @amotl !

@ivelin
Copy link
Contributor

ivelin commented Jan 14, 2021

I don't know why commit-lint-pr fails on my commit. Maybe you can give me a clue?

It requires semantic release convention for commit message subject: https://www.conventionalcommits.org/en/v1.0.0/#summary

@ivelin ivelin linked an issue Jan 14, 2021 that may be closed by this pull request
@ivelin ivelin merged commit 9eb3c01 into ambianic:master Jan 14, 2021
@amotl amotl deleted the amo/fix-build branch January 14, 2021 14:19
@amotl
Copy link
Contributor Author

amotl commented Jan 14, 2021

Hi Ivelin,

Very cool. Thank you @amotl!

You are welcome, glad to help.

Commits require semantic release convention for commit message subject.

I already had a look at this and tried my best to satisfy this linter. Can you tell me where exactly the commit message failed on that? (I also tried with lowercase "f" but it didn't make any difference)

Fix: Attempt to make the CI build work on Python 3.9 

With kind regards,
Andreas.

@ivelin ivelin mentioned this pull request Jan 14, 2021
@ivelin
Copy link
Contributor

ivelin commented Jan 14, 2021

Yes, it's a bit too particular for my taste as well. It doesn't want upper case in the subject. Try:

fix: attempt to make the CI build work on Python 3.9 
@ivelin
Copy link
Contributor

ivelin commented Jan 15, 2021

🎉 This PR is included in version 1.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants