Skip to content

Conversation

@cdhawke
Copy link
Contributor

@cdhawke cdhawke commented Oct 30, 2025

🧭 What and Why

Related to work on dark experimentation, we are removing the schedule endpoints from our abtesting api - they have not been used in over a year and are costing us infrastructure resources and code maintenance debt when adding new features.

Changes included:

  • removing schedule functionality from abtests v3 and v2 clients

🧪 Test

  • updated to remove requests
@cdhawke cdhawke requested a review from a team October 30, 2025 00:11
@cdhawke cdhawke self-assigned this Oct 30, 2025
@cdhawke cdhawke requested a review from a team as a code owner October 30, 2025 00:11
@cdhawke cdhawke requested review from millotp and shortcuts October 30, 2025 00:11
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 30, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by f0850ecb21652976f5e2e822a339d7e1541cf524
🍃 Generated commit f29ef39dcfeb16cfde44dcceaaf9332e5f6c6f5b
🌲 Generated branch generated/feat/abtests/remove-schedule
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1725
javascript 1591
php 1471
csharp 1351
python 1138
java 993
ruby 812
swift 581
scala 23
@cdhawke cdhawke changed the title feat(abtests): remove schedule capabilities feat(clients): remove schedule capabilities Oct 30, 2025
@cdhawke
Copy link
Contributor Author

cdhawke commented Oct 30, 2025

@millotp - i'm not really sure why the javascript build is failing... I can't find any other references to the schedule response that it's complaining about. any idea where I can look?

@shortcuts
Copy link
Member

@cdhawke you have to remove the type you just removed from the spec from templates/javascript/clients/algoliasearch/builds/models.mustache as well as it manually references it

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you

@shortcuts shortcuts enabled auto-merge (squash) October 30, 2025 15:01
@shortcuts shortcuts merged commit ecfea56 into main Oct 30, 2025
53 of 55 checks passed
@shortcuts shortcuts deleted the feat/abtests/remove-schedule branch October 30, 2025 16:56
algolia-bot added a commit that referenced this pull request Oct 30, 2025
… ci] Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 30, 2025
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants