- Notifications
You must be signed in to change notification settings - Fork 27
feat(clients): remove schedule capabilities #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
| @millotp - i'm not really sure why the javascript build is failing... I can't find any other references to the schedule response that it's complaining about. any idea where I can look? |
| @cdhawke you have to remove the type you just removed from the spec from templates/javascript/clients/algoliasearch/builds/models.mustache as well as it manually references it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thank you
… ci] Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#5552 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
🧭 What and Why
Related to work on dark experimentation, we are removing the schedule endpoints from our abtesting api - they have not been used in over a year and are costing us infrastructure resources and code maintenance debt when adding new features.
Changes included:
schedulefunctionality from abtests v3 and v2 clients🧪 Test