Fix issue 286: Line numbers do not align with lines #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nausharipov approved these changes Jul 27, 2025
razankv13 added a commit to zingdata/flutter-code-editor that referenced this pull request Oct 20, 2025
This merge brings in important bug fixes and features from main while preserving all autocomplete/suggestions improvements from improve-editor branch. Changes from main integrated: - Flutter/Dart version upgrade (3.22.2/3.4.3) - Dispose fixes (akvelon#298): Added _disposed flag and mounted checks - UndoHistoryController support (akvelon#302) - Line height in default text style fix (akvelon#297) - YAML support and comments (akvelon#305, akvelon#199) - JS/TS single line comments (akvelon#291) - Paired symbols support (akvelon#192) - Line numbers alignment fix (akvelon#307) - Pull request template - Various dependency updates Changes preserved from improve-editor: - Refactored code_controller structure (directory with helpers) - SQL formatter and suggestions logic - Word insertion helper - Popup positioning improvements - Gutter scrollbar hiding - Browser detection enhancements - All autocomplete/suggestions improvements Conflicts resolved: - code_field.dart: Integrated dispose, undo, and line height fixes - code_controller.dart: Kept refactored structure, added dispose fix - gutter.dart: Kept scrollbar hiding feature - popup.dart & popup_controller.dart: Kept positioning improvements - parser_factory.dart: Added YAML support with package imports 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
After reviewing this issue #286 I discovered that the solution to the problem was to add a default height to defaultTextStyle. In this case, the default height comes from the themeData itself.
With this change, no workaround would be necessary.
Added tests?
Added to documentation?