Skip to content

Conversation

@nausharipov
Copy link
Collaborator

flutter pub outdated: Showing outdated packages. [*] indicates versions that are not the latest available. Package Name Current Upgradable Resolvable Latest direct dependencies: all up-to-date. dev_dependencies: all up-to-date. all dependencies are up-to-date. 
flutter test: 00:31 +271: All tests passed! 
flutter doctor: Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.13.6, on macOS 14.0 23A344 darwin-x64, locale en-KZ) [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2) [✓] Xcode - develop for iOS and macOS (Xcode 15.0) [✓] Chrome - develop for the web [✓] Android Studio (version 2022.1) [✓] VS Code (version 1.83.0) [✓] Connected device (2 available) [✓] Network resources • No issues found! 

example/lib/02.code_field % flutter run:
Screenshot 2023-10-11 at 19 25 34

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (149888a) 82.61% compared to head (2bbd103) 82.60%.

Additional details and impacted files
@@ Coverage Diff @@ ## main #256 +/- ## ========================================== - Coverage 82.61% 82.60% -0.02%  ========================================== Files 107 107 Lines 3163 3161 -2 ========================================== - Hits 2613 2611 -2  Misses 550 550 
Files Coverage Δ
lib/src/search/controller.dart 78.46% <100.00%> (-0.65%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nausharipov nausharipov requested a review from yescorp October 17, 2023 05:53
controller.value = controller.value;
controller.value = controller.value.typed('a');
controller.value = controller.value.typed('b');
controller.value = controller.value;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful to test that changing to the same value doesn't create a history record

Copy link
Collaborator

@yescorp yescorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nausharipov nausharipov requested a review from yescorp October 17, 2023 07:09
@nausharipov nausharipov merged commit d7e4beb into main Oct 17, 2023
@nausharipov nausharipov deleted the flutter-pub-upgrade-11-10-23 branch October 17, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants