Fixed edge case where ecid may start with 0x #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
java.lang.NumberFormatException: For input string: "0x162431234501E" under radix 16 at java.base/java.lang.NumberFormatException.forInputString(Unknown Source) at java.base/java.lang.Long.parseLong(Unknown Source) at airsquared.blobsaver@3.3.0/airsquared.blobsaver.app.TSS.saveBlobsTSSSaver(Unknown Source) at airsquared.blobsaver@3.3.0/airsquared.blobsaver.app.TSS.call(Unknown Source) at airsquared.blobsaver@3.3.0/airsquared.blobsaver.app.TSS.call(Unknown Source) at javafx.graphics@19/javafx.concurrent.Task$TaskCallable.call(Unknown Source) at java.base/java.util.concurrent.FutureTask.run(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source)
Fixed edge case where ecid may start with 0x
| Could this cause issues when a user has an ECID that is only digits, even in hex representation? (see #272) |
| I just realized, it doesn't matter because the radix is specified as 16 when calling |
airsquared added a commit that referenced this pull request Dec 12, 2022
This reverts commit 9099daa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using a program such as checkra1n the ecid may start with 0x.
This causes the exception seen below. I wrote this quick patch, it is untested but the general idea should be there. My actual ecid is the only piece of information I spoofed in the exception below.