Skip to content

[MINOR] Fix possible 404 errors + get rid of unnecessary arguments #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ValentinFrancois merged 8 commits into from
Mar 6, 2022
Merged

[MINOR] Fix possible 404 errors + get rid of unnecessary arguments #18

ValentinFrancois merged 8 commits into from
Mar 6, 2022

Conversation

@ValentinFrancois
Copy link
Owner

@ValentinFrancois ValentinFrancois commented Mar 6, 2022 •
edited
Loading

MINOR (BREAKING):

  • removed argument get_latest_commit_possible_if_not_found: bool
  • removed argument get_latest_commit_possible_ref: Optional[str]

Both were obsolete since #15

PATCH:

  • fix uncaught 404 errors when the .gitmodules file contains urls to unexisting repos or paths that don't exist in the host repo
@ValentinFrancois ValentinFrancois changed the title [MAJOR] Fix possible 404 errors + get rid of unnecessary arguments [MINOR] Fix possible 404 errors + get rid of unnecessary arguments Mar 6, 2022
@ValentinFrancois ValentinFrancois merged commit 63987d5 into main Mar 6, 2022
@ValentinFrancois ValentinFrancois deleted the fix-404-errors branch March 6, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ValentinFrancois