Skip to content

Conversation

@HRIDYANSHU054
Copy link
Contributor

@HRIDYANSHU054 HRIDYANSHU054 commented Oct 23, 2024

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
    Added tests for Maths/DecimalIsolate function and improved comments on its usage
    Before:
/*  * function isolates the decimal part of a number.  * Take the number and subtract it from the floored number.  * Return the result.  */

Now:

/*  * This function isolates the decimal part of a number.  * - If input is a number or a numeric string, it isolates and returns the decimal part.  * - If input is an array:  * - It isolates the decimal part of the first element.  * - If the array contains more than one element, only the first element is considered.  * - If the array is empty, it returns 0.  * - If input is not a number, a numeric string, or a valid first element array,  * the function returns 0.  */

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (ff314a2) to head (73b2a5e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1749 +/- ## ========================================== + Coverage 84.76% 84.86% +0.09%  ========================================== Files 378 379 +1 Lines 19742 19804 +62 Branches 2955 2967 +12 ========================================== + Hits 16735 16807 +72  + Misses 3007 2997 -10 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HRIDYANSHU054
Copy link
Contributor Author

@appgurueu @raklaptudirm
kindly check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants