Skip to content

Conversation

@kevinliao2003
Copy link

Open in Gitpod know more

Describe your change:

  • added a lettercombos.js file that computes the phone number combinations of a string and added tests

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@appgurueu
Copy link
Collaborator

appgurueu commented Jan 3, 2024

This is effectively just a special case of a generalized cartesian product. Having a cartesian product abstraction in this repo might be neat, but this application of it is too oddly specific.

@appgurueu appgurueu closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants