Skip to content

Conversation

@pomkarnath98
Copy link
Member

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@pomkarnath98 pomkarnath98 added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2023
@pomkarnath98
Copy link
Member Author

Added hacktoberfest-accepted labels because of only test cases added, which are verified.

@raklaptudirm raklaptudirm removed the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2023
@raklaptudirm
Copy link
Member

As @appgurueu said, the label is unnecessary. Also I would suggest letting the reviewers add the label if and when they see fit.

@pomkarnath98
Copy link
Member Author

pomkarnath98 commented Oct 24, 2023

As @appgurueu said, the label is unnecessary. Also I would suggest letting the reviewers add the label if and when they see fit.

Umm okay @raklaptudirm. That's noted! Just did it for the sake of Hacktoberfest : )
However, you can still review the PR and lemme know in case of changes.

@pomkarnath98 pomkarnath98 mentioned this pull request Oct 24, 2023
11 tasks
@pomkarnath98 pomkarnath98 mentioned this pull request Oct 25, 2023
11 tasks
@raklaptudirm raklaptudirm merged commit f67cdc3 into TheAlgorithms:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants