Skip to content

Conversation

@RS-labhub
Copy link

@RS-labhub RS-labhub commented Oct 22, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@RS-labhub
Copy link
Author

@raklaptudirm please review this code!

@appgurueu appgurueu added the invalid Doesn't seem right label Oct 27, 2023
@appgurueu
Copy link
Collaborator

Please refer to our contribution guidelines; a proper PR should be using ES modules (not HTML), have a JSDoc comment, tests, and not be invoking side effects like console.log. This implementation is also not really reusable, since it uses a fixed-size hash table hardcoded to 10 slots, and does not seem to deal with collisions at all (I would consider that a broken hash table).

@appgurueu appgurueu closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Doesn't seem right

2 participants